Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to support system packages in venv #313

Merged
merged 1 commit into from Nov 25, 2022

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Oct 18, 2020

Adds parameter to support system packages in venv.

Copy link
Member

@ghoneycutt ghoneycutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the trivial nature of the commit, that it does not introduce new conditionals and that the current spec tests are so minimal, I think this is fine to merge as is once it is rebased.

If there were already some spec tests around an existing param, I would hold up merging and say copy/paste the existing one and change it for the new param, but that's not the case here.

@ghoneycutt
Copy link
Member

@h0tw1r3 Could you please rebase? That will allow this to be merged.

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Apr 12, 2021

rebased

@vox-pupuli-tasks
Copy link

Dear @h0tw1r3, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @h0tw1r3, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Nov 25, 2022

rebased again

@smortex smortex added enhancement New feature or request and removed tests-fail merge-conflicts labels Nov 25, 2022
@smortex
Copy link
Member

smortex commented Nov 25, 2022

Given the trivial nature of the commit, that it does not introduce new conditionals and that the current spec tests are so minimal, I think this is fine to merge as is once it is rebased.

Same feeling here. I am removing the needs-test label. If people are not happy with this, feel free to re-add the label ;-)

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex merged commit b1c8182 into voxpupuli:master Nov 25, 2022
@smortex smortex changed the title support for venv system packages Add parameter to support system packages in venv Nov 25, 2022
@h0tw1r3 h0tw1r3 deleted the support-systempkgs branch November 26, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants