New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter to support system packages in venv #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the trivial nature of the commit, that it does not introduce new conditionals and that the current spec tests are so minimal, I think this is fine to merge as is once it is rebased.
If there were already some spec tests around an existing param, I would hold up merging and say copy/paste the existing one and change it for the new param, but that's not the case here.
@h0tw1r3 Could you please rebase? That will allow this to be merged. |
2d68b8b
to
34133d5
Compare
rebased |
Dear @h0tw1r3, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Dear @h0tw1r3, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
34133d5
to
faf2beb
Compare
rebased again |
Same feeling here. I am removing the needs-test label. If people are not happy with this, feel free to re-add the label ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds parameter to support system packages in venv.