Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .htaccess files #88

Merged
merged 1 commit into from
Feb 20, 2016
Merged

Conversation

tombuildsstuff
Copy link
Contributor

Added a means of setting the apache AllowOverride setting (required to allow .htaccess files) - defaults to 'None' in the Apache::VHost resource

@igalic
Copy link
Contributor

igalic commented Oct 23, 2015

do we need a README update for this?

@tombuildsstuff
Copy link
Contributor Author

@igalic happy to update it - just let me know :)

@ffrank
Copy link

ffrank commented Oct 26, 2015

Yes, please. Feel free to squash commits, but in this case I would be fine with a two commit branch.

What's wrong with PCCI? Thoughts @nibalizer?

[Note, I'm a little sad that we have to expose Apache options this way, but what are you going to do.]

@igalic
Copy link
Contributor

igalic commented Oct 27, 2015

[@ffrank: you could do something like PUP-4669]

@ffrank
Copy link

ffrank commented Oct 27, 2015

[@igalic well, -ish. Where the main interface of a module is concerned, this pattern will likely not match, because you can easily have several resources like that which you want to be configurable.]
[[Meta-convo this way feels silly and I love it.]]

@igalic
Copy link
Contributor

igalic commented Oct 27, 2015

[@ffrank: yes, but you could always use an $apache_* prefix which you'd use to forward to the apache vhost…, and perhaps a different prefix for, say, $vcsrepo_*, as also described in said issue]

@tombuildsstuff
Copy link
Contributor Author

@igalic @ffrank sorry - what is it you want me to do here? squash the commits and add documentation?

I guess the other way to handle this would be a default hash provided in this class - with overrides passed in and merged together using an ensure_resource?

@igalic
Copy link
Contributor

igalic commented Dec 22, 2015

sound good, yes!

@jyaworski
Copy link
Member

Hello:

What is the status of this PR? Is it just failing PCCI, and can we merge regardless?

jyaworski added a commit that referenced this pull request Feb 20, 2016
@jyaworski jyaworski merged commit e168a93 into voxpupuli:master Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants