Add config class and some basic params. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
force-pushed
the
add_default_config_data
branch
4 times, most recently
from
c6213c3
to
e026169
Compare
bastelfreak
reviewed
Oct 8, 2018
| class { 'puppetwebhook': } | ||
| MANIFEST | ||
|
|
||
| apply_manifest(pp, catch_failures: true) |
There was a problem hiding this comment.
we should always run it twice, to check for idempotence?
There was a problem hiding this comment.
It will eventually. That was there for validating that the to_yaml() function did what was expected. I'm not sure I'm ready to test for idempotency. That will come once the service class is done
bastelfreak
approved these changes
Oct 8, 2018
dhollinger
force-pushed
the
add_default_config_data
branch
from
e026169
to
023cc13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.