Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Webhook does not support Ping event from GitHub #89

Closed
elyscape opened this issue Nov 12, 2014 · 2 comments
Closed

[Bug] Webhook does not support Ping event from GitHub #89

elyscape opened this issue Nov 12, 2014 · 2 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone
Version 3.0

Comments

@elyscape
Copy link
Contributor

When setting up a new webhook service on GitHub, it sends a Ping event to the service to test the connection. The webhook service provided here doesn't support this, and gives an HTTP 500 error and a bunch of HTML with the issue. It looks like the problem is with line 84 of the webhook code:

branch = ( data['ref'] || data['refChanges'][0]['refId'] ).split("/").last

ref and refChanges don't exist in a ping event, so this explodes.
@acidprime
Copy link
Collaborator

I will add this to the next version of the webhook, I need to create some feature tickets for this and supporting their secret instead of the basic auth it does not. I have mostly been waiting to write beaker tests for this as changing the webhook can effect quite a few people and spec tests won;t cut it.

@acidprime acidprime added this to the Version 3.0 milestone Feb 23, 2015
@acidprime acidprime added the enhancement New feature or request label Feb 23, 2015
@acidprime acidprime added the bug Something isn't working label Apr 21, 2015
@acidprime acidprime changed the title Webhook does not support Ping event from GitHub [Bug] Webhook does not support Ping event from GitHub Apr 21, 2015
acidprime pushed a commit that referenced this issue Apr 23, 2015
Add failure support for webhook Fix #89
016f2f7 
Prior to this commit we would fail with a track if the payload
did not contain the correct hash information. This puts a simple
rescue to cover this.
@brandonweeks
Copy link
Contributor

This was actually fixed in #201 after I created the duplicate issue #200.

@elyscape elyscape closed this as completed Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
3 participants
@brandonweeks @elyscape @acidprime