New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update travis config, minor lint fixes #29
Conversation
@@ -23,7 +23,7 @@ | |||
# Gentoo specific values | |||
$gentoo_keywords = '' | |||
|
|||
if $::is_pe == 'true' { | |||
if $::is_pe == true { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fact so its not actually a boolean, other then that looks good
Also need to rebase now. |
So I had to revert this for a couple of reasons
and line 25 of the travis file had the wrong indenting. If you want to update your branch I will get it merged, but I won't have time until next week end. Thanks for the PR |
Gemfile did not get updated ^^ |
Update travis for puppet 3.1, 3.2, 3.3, 3.4
Add puppet-lint checking
Add puppet-syntax checking
Minor lint fixes