Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis config, minor lint fixes #29

Merged
merged 1 commit into from Feb 9, 2014

Conversation

jlambert121
Copy link
Contributor

Update travis for puppet 3.1, 3.2, 3.3, 3.4
Add puppet-lint checking
Add puppet-syntax checking
Minor lint fixes

@@ -23,7 +23,7 @@
# Gentoo specific values
$gentoo_keywords = ''

if $::is_pe == 'true' {
if $::is_pe == true {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fact so its not actually a boolean, other then that looks good

@acidprime
Copy link
Collaborator

Also need to rebase now.

@acidprime acidprime merged commit d001d9c into voxpupuli:master Feb 9, 2014
@acidprime
Copy link
Collaborator

So I had to revert this for a couple of reasons

Using worker: worker-linux-2-2.bb.travis-ci.org:travis-linux-20
$ export PUPPET_VERSION="~> 3.4.0"
git.1
$ git clone --depth=50 --branch=master git://github.com/acidprime/r10k.git acidprime/r10k
Cloning into 'acidprime/r10k'...
remote: Counting objects: 377, done.
remote: Compressing objects: 100% (200/200), done.
remote: Total 377 (delta 196), reused 336 (delta 160)
Receiving objects: 100% (377/377), 52.57 KiB | 0 bytes/s, done.
Resolving deltas: 100% (196/196), done.
Checking connectivity... done.
$ cd acidprime/r10k
git.3
$ git checkout -qf 7b0a6553f8dee0f9b9b7fe93699c3aa42249bc9b
$ rvm use 1.8.7 --install --binary --fuzzy
Using /home/travis/.rvm/gems/ruby-1.8.7-p374
$ export BUNDLE_GEMFILE=$PWD/Gemfile
$ ruby --version
ruby 1.8.7 (2013-06-27 patchlevel 374) [x86_64-linux]
$ rvm --version
rvm 1.25.16 (latest-minor) by Wayne E. Seguin <wayneeseguin@gmail.com>, Michal Papis <mpapis@gmail.com> [https://rvm.io/]
$ gem --version
2.2.1
$ bundle --version
Bundler version 1.5.2
install
$ bundle install --without development
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Using rake (10.1.1)
Installing builder (3.2.2)
Installing diff-lcs (1.2.5)
Installing excon (0.31.0)
Installing facter (1.7.4)
Installing formatador (0.2.4)
Installing mime-types (1.25.1)
Installing multi_json (1.8.4)
Installing net-ssh (2.8.0)
Installing net-scp (1.1.2)
Installing nokogiri (1.5.11)
Installing fog (1.20.0)
Installing json_pure (1.8.1)
Installing hiera (1.3.1)
Installing highline (1.6.20)
Installing kwalify (0.7.2)
Installing metaclass (0.0.2)
Installing mocha (1.0.0)
Installing rgen (0.6.6)
Installing puppet (3.4.2)
Installing puppet-lint (0.3.2)
Installing rspec-core (2.14.7)
Installing rspec-expectations (2.14.5)
Installing rspec-mocks (2.14.5)
Installing rspec (2.14.1)
Installing rspec-puppet (1.0.1)
Installing puppetlabs_spec_helper (0.4.1)
Installing trollop (2.0)
Installing rbvmomi (1.8.1)
Installing systemu (2.6.0)
Installing rspec-system (2.8.0)
Installing rspec-system-puppet (2.2.1)
Installing specinfra (0.5.6)
Installing serverspec (0.15.2)
Installing rspec-system-serverspec (2.0.1)
Using bundler (1.5.2)
Your bundle is complete!
Gems in the group development were not installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
$ rake lint
rake aborted!
no such file to load -- puppet-syntax/tasks/puppet-syntax
/home/travis/build/acidprime/r10k/Rakefile:3
(See full trace by running task with --trace)
The command "rake lint" exited with 1.
$ rake syntax
rake aborted!
no such file to load -- puppet-syntax/tasks/puppet-syntax
/home/travis/build/acidprime/r10k/Rakefile:3
(See full trace by running task with --trace)
The command "rake syntax" exited with 1.
$ rake spec SPEC_OPTS='--format documentation'
rake aborted!
no such file to load -- puppet-syntax/tasks/puppet-syntax
/home/travis/build/acidprime/r10k/Rakefile:3
(See full trace by running task with --trace)
The command "rake spec SPEC_OPTS='--format documentation'" exited with 1.
Done. Your build exited with 1.

and line 25 of the travis file had the wrong indenting.

If you want to update your branch I will get it merged, but I won't have time until next week end.

Thanks for the PR

@acidprime
Copy link
Collaborator

Gemfile did not get updated ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants