Attempted fix for issue#25 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump... |
|
@tfhartmann this looks good, can you please rebase and I will get it merged |
I updated the template to loop through the hash keys rather then create the YAML from the hash, the to_yaml method was all kinds of unhelpful, although it does seem to be a nicer way to do this. I didn't have much luck with getting the to_yaml method options working the way I wanted, so fell back to this method.
|
done and done :) |
|
@acidprime not trying to be a bother, but if this is cool would you mind merging it in? I'd like to use this module in our env, and would rather use your version from git until these make it into a forge release. |
|
@acidprime bump, please. I'm looking forward to my puppet master not showing that something changed every few runs. :) |
|
Thanks @acidprime |
|
Tagged at https://github.com/acidprime/r10k/releases/tag/v2.0.0 , can't push to forge until I resolve some refactor issues with the webhook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25
I updated the template to loop through the hash keys rather then
create the YAML from the hash, the to_yaml method was all kinds of
unhelpful, although it does seem to be a nicer way to do this.
I didn't have much luck with getting the to_yaml method options
working the way I wanted, so fell back to this method.