Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop quoting all configuration options so that prefix is not always on #51

Merged
merged 1 commit into from Jun 4, 2014

Conversation

ghoneycutt
Copy link
Member

Without this patch, prefix could be set to "false" which is not a
boolean and gets interpreted as true. This could result in your branches
being prefixed with 'puppet_'.

Without this patch, prefix could be set to "false" which is not a
boolean and gets interpreted as true. This could result in your branches
being prefixed with 'puppet_'.
@ghoneycutt
Copy link
Member Author

@acidprime upgraded to 2.1.0 today and it busted my production environment since the environment name changed from production to puppet_production. Suggest updating the CHANGELOG to warn people not to use 2.1.0 and to use 2.1.1 or whatever you tag this release as.

acidprime added a commit that referenced this pull request Jun 4, 2014
Stop quoting all configuration options so that prefix is not always on
@acidprime acidprime merged commit 6626a8a into voxpupuli:master Jun 4, 2014
@acidprime
Copy link
Collaborator

@ghoneycutt good catch thanks for being the guiney pig, might want to put some condtional logic eventually so we quote everything but boolean.

Rolled webhook changes and your fix into this tag

https://github.com/acidprime/r10k/releases/tag/v2.1.2

good point on the change log its lagging behind.

@ghoneycutt
Copy link
Member Author

Thanks Zach! Thought the same thing with making the quoting smarter, though I tried not quoting my remote and all is well since yaml will treat it as a string without quotes.

@ghoneycutt ghoneycutt deleted the fix_prefix_always_on_bug branch June 4, 2014 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants