Removed symlinked r10k fixture/modules directory. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added r10k to .fixtures.yaml to allow puppetlabs_spec_helper to handle the symlinking of the module at runtime. Added /spec/fixture/module/.gitignore to keep empty directory for testing purposes. removed spec/fixtures exclusion from .gitignore to maintain the spec/fixtures/modules directory.
|
+1 |
acidprime
added a commit
that referenced
this pull request
Jul 7, 2014
Removed symlinked r10k fixture/modules directory.
|
Nice catch, and thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve #43. It turns out the issue revolves around the symlinked directories in the spec/fixtures/module/r10k directory. Removing those and allowing puppetlabs_spec_helper to symlink at runtime of the tests both resolves the issue, as well as maintains the testing process. This has been tested against PE 3.2.3.