-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forced to run twice due to failing provider detection #95
Comments
run puppet a second time and it works fine, it is just the first time where it fails. |
try reverting this patch and see if it works:
This patch looks like it would result in that behavior |
Hmm, this is unexpected (and of course I can't reproduce it easily in testing). I can confirm what you're seeing via vagrant and it's definitely odd. We do a rabbitmqctl list_users -q and look for 'unable to connect to node'. If we get that we fail out the providers. I can see that the service refreshed and is running prior to the first attempted load of the provider, so this should work. At least my understanding was that providers don't run the :confine block until they are actually called for the first time so it shouldn't have done it up front and cached that result past the start of the service. I'm torn over the right thing to do here. We want the provider to fail if the service isn't up so users don't have to specify their own requires, but if this is going to fail on every first run then it won't do. I'll dig into this a little more and see if I can find out exactly what is happening. |
Yeah, I can confirm reverting that code resolved the issue as well. Thanks |
I'll give in and switch these over to just autorequires the service. I wanted to avoid that as I couldn't autorequires the service but it seems like a cleaner solution and should hopefully work for a first run. Testing with your vagrant and the changes: Notice: /Stage[main]/Roles::Middleware/Rabbitmq_user[mcollective]/ensure: created I'll get a PR in to make these changes. |
Yeah, works great for me. Thanks. |
Awesome, closing this for now then! |
u can checkout my https://github.com/zeph/mcollective-lnmp and type "vagrant up" to see it
u need to rekick puppet via "vagrant provision" to see it succeed
The text was updated successfully, but these errors were encountered: