Refactor rabbitmq_user provider (mpolenchuk)

[wyardley]

This is an attempt to rework #460 by @mpolenchuk (keeping original attribution).
Could use careful review, rebasing was pretty hairy, and not sure I got everything.

As of now, failing at least one test.

[wyardley]

@ekohl @hunner I think this is ready for review, and would very much appreciate a review on this one if at all possible. In particular, I think the tests could use some improvement, especially for the change password situation.

However, at a functional level, I think this is working(ish), and an improvement.

[wyardley]

I don't think this is doing anything useful, but need to come up with a better test here.

[wyardley]

@mpolenchuk - don't know if you've got time to review, but let me know if this looks sane. I'm still trying to come up with a better test case for the password change bit.

[ekohl]

You can use newproperty(:admin, boolean: true, parent: Parent::Property::Boolean) and remove the body (except desc). Then you can use true booleans in the provider. You might need a require 'puppet/property/boolean but I'm not sure about that.

[wyardley]

I think this is a good idea, but I feel like it should be implemented separately, and then we can review all the type parameters at once, and adjust any that we can switch to true booleans / integers / etc in one 'breaking' changeset.

[ekohl]

That's fair

[wyardley]

It seems like the existing code is (in some cases) as simple as:

  newparam(:force) do
    defaultto(:false)
    newvalues(:true, :false)
  end

which actually seems simpler than the suggested code in https://docs.puppet.com/puppet/5.1/custom_types.html, and without that extra require. Also, the puppet boolean type allows 'true' yes, and various other things, which seems kind of regressive.

[coveralls]

Changes Unknown when pulling e6407e2 on wyardley:rework_pull_460 into ** on voxpupuli:master**.

[coveralls]

Changes Unknown when pulling e6407e2 on wyardley:rework_pull_460 into ** on voxpupuli:master**.

[coveralls]

Changes Unknown when pulling e6407e2 on wyardley:rework_pull_460 into ** on voxpupuli:master**.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling 343006b on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling 343006b on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling 343006b on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling fe41806 on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling fe41806 on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling 50358fc on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[wyardley]

@ekohl: the shared example seems to get executed after the other elements in the block, which is causing an ordering issue.
For example

    it_behaves_like 'an idempotent resource'

    it 'does not have the user' do
      shell('rabbitmqctl list_users -q') do |r|
        expect(r.stdout).not_to match(%r{dan\s+})
      end
    end

results in

  destroy user resource
    does not have the user (FAILED - 1)
    behaves like an idempotent resource
localhost $ scp /var/folders/0z/yrnglm6n1l5_q19dv1yy0w3c0000gn/T/beaker20170913-21543-xcrm0o centos-7-x64:/tmp/apply_manifest.pp.Kz0FfQ {:ignore => }
      applies with no errors
localhost $ scp /var/folders/0z/yrnglm6n1l5_q19dv1yy0w3c0000gn/T/beaker20170913-21543-ez5qfe centos-7-x64:/tmp/apply_manifest.pp.BUFI7K {:ignore => }
      applies a second time without changes

It's failing because the test for the user being gone runs before the shared example runs.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling 6974325 on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling e3730f6 on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.

[coveralls]

Coverage increased (+0.3%) to 78.959% when pulling e3730f6 on wyardley:rework_pull_460 into 3a5268d on voxpupuli:master.