Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable usage of custom list of plugins when using static config file #917

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

enothen
Copy link

@enothen enothen commented Nov 22, 2022

This PR enables usage of a custom list of plugins when using a plugins config file, as reported on #916
Fixes #916

@enothen
Copy link
Author

enothen commented Nov 22, 2022

Hello reviewers,
Not sure how to handle the failed validation, as it was already in master before this PR:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
$ git log --oneline |head -5
138a977 [blacksmith] Bump version to 12.0.3-rc0
7f384ce Merge pull request #914 from wyardley/wyardley/release_12_0_2
79949c2 Release 12.0.2
3f811e5 Merge pull request #912 from kvisle/bugfix/plugin_resource_broken_310
3436f22 Make rabbitmq_plugin resource functional on RabbitMQ 3.10.x
$ bundle exec rake lint
manifests/config.pp:131:manifest_whitespace_opening_brace_before:ERROR:there should be a single space before an opening brace

Since the problem is unrelated to this PR, should I fix it here or open a separate issue?

@wyardley
Copy link
Contributor

Hi. Yes, can you make a separate PR with just that fix? It passed on the last run I can find.

@enothen
Copy link
Author

enothen commented Nov 22, 2022

Hi. Yes, can you make a separate PR with just that fix? It passed on the last run I can find.

Done, #918

@enothen
Copy link
Author

enothen commented Nov 24, 2022

Can someone please rerun the tests? They should be fone now that #918 is merged.

@kenyon
Copy link
Member

kenyon commented Nov 24, 2022

Rebasing on current master will rerun the tests.

@enothen
Copy link
Author

enothen commented Nov 24, 2022

Rebasing on current master will rerun the tests.

Thanks. Rebased, fixed a syntax warning in the test case, squashed and pushed again. Now I'm getting a failed job just on Archlinux, but seems to be unrelated to the changes. I'm not so sure what to make out of the logs yet.

@wyardley
Copy link
Contributor

Yeah, arch failures have been there a while and are unrelated.

@wyardley wyardley merged commit aa675b8 into voxpupuli:master Nov 30, 2022
@wyardley wyardley added the enhancement New feature or request label Nov 30, 2022
@wyardley wyardley mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use custom list inside enabled_plugins file
4 participants