Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata.json: re-add Puppet 8 support #985

Merged
merged 2 commits into from
May 19, 2024

Conversation

bastelfreak
Copy link
Member

This was removed by mistake previously.

@bastelfreak bastelfreak added the bug Something isn't working label May 19, 2024
@bastelfreak bastelfreak self-assigned this May 19, 2024
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you merge it as "re add" or "re-add"? I think "readd" is easy to parse as a typo of "read" at quick glance.

@wyardley
Copy link
Contributor

@bastelfreak I came across this error in some other recent PRs (where with certain OS / RMQ versions, the user gets configured as rabbit vs. rabbit_cluster. It makes no sense to me, since the configs should still be properly defining it, but maybe a provider issue?

@bastelfreak bastelfreak changed the title metadata.json: Readd Puppet 8 support metadata.json: re-add Puppet 8 support May 19, 2024
@bastelfreak
Copy link
Member Author

puppet 8:

Failure/Error: expect(r.stdout).to match(%r!({cluster_name,<<"rabbit_cluster">>}|^Cluster name: rabbit_cluster$)!)
  expected "[{nodes,[{disc,['rabbit@centos7-64-puppet8']}]},\n {running_nodes,['rabbit@centos7-64-puppet8']},\n {cluster_name,<<\"rabbit@centos7-64-puppet8.example.com\">>},\n {partitions,[]}]\n" to match /({cluster_name,<<"rabbit_cluster">>}|^Cluster name: rabbit_cluster$)/
  Diff:
  @@ -1,4 +1,7 @@
  -/({cluster_name,<<"rabbit_cluster">>}|^Cluster name: rabbit_cluster$)/
  +[{nodes,[{disc,['rabbit@centos7-64-puppet8']}]},
  + {running_nodes,['rabbit@centos7-64-puppet8']},
  + {cluster_name,<<"rabbit@centos7-64-puppet8.example.com">>},
  + {partitions,[]}]

vs puppet 7:

centos7-64-puppet7.example.com 17:13:19$ rabbitmqctl -q cluster_status
  [{nodes,[{disc,['rabbit@centos7-64-puppet7']}]},
   {running_nodes,['rabbit@centos7-64-puppet7']},
   {cluster_name,<<"rabbit_cluster">>},
   {partitions,[]}]

@bastelfreak bastelfreak merged commit 3eb88dd into voxpupuli:master May 19, 2024
10 checks passed
@bastelfreak bastelfreak deleted the puppet82 branch May 19, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants