Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make content parameter optional #39

Merged
merged 3 commits into from Oct 6, 2022
Merged

Make content parameter optional #39

merged 3 commits into from Oct 6, 2022

Conversation

smortex
Copy link
Member

@smortex smortex commented Oct 4, 2022

Our CI pipeline does not like default empty strings, and an empty string is not an useful rc-script, so change the content data type to be an optional non-empty String.

This PR also include:

Our CI pipeline does not like default empty strings, and an empty string
is not an useful rc-script, so change the content data type to be an
optional non-empty String.
@smortex smortex changed the title Make content parameter mandatory Make content parameter optional Oct 5, 2022
@bastelfreak bastelfreak merged commit 36a2d09 into master Oct 6, 2022
@bastelfreak bastelfreak deleted the mandatory-content branch October 6, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants