Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 20.04 support #357

Merged
merged 1 commit into from May 19, 2020
Merged

Add Ubuntu 20.04 support #357

merged 1 commit into from May 19, 2020

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented May 9, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@mmoll
Copy link
Contributor Author

mmoll commented May 9, 2020

needs to wait for a bolt release...

@@ -38,6 +38,10 @@ matrix:
bundler_args: --without development release
env: PUPPET_INSTALL_TYPE=agent BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_debug=true BEAKER_setfile=ubuntu1804-64m BEAKER_HYPERVISOR=docker CHECK=beaker
services: docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task for Puppet 5 is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no puppet-agent 5.x for focal and I'm unsure if it will be released, but let's wait and see. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it wasn't for Debian 10 so I doubt we'll see it for Ubuntu 20.04

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be no packages for Puppet 5:

@bastelfreak bastelfreak added the enhancement New feature or request label May 10, 2020
@ekohl
Copy link
Member

ekohl commented May 10, 2020

Looks like there is no puppet-bolt package for Ubuntu 20.04. Should we skip that for now?

@mmoll
Copy link
Contributor Author

mmoll commented May 10, 2020

I'd wait for the release as I need the integration tests to be sure, it works.

@mmoll
Copy link
Contributor Author

mmoll commented May 19, 2020

Seems like this is working OOTB. 💚

@mmoll mmoll removed the tests-fail label May 19, 2020
@ekohl
Copy link
Member

ekohl commented May 19, 2020

@dhoppe you requested changes, but I think those are no longer relevant now? Mind merging?

@dhoppe
Copy link
Member

dhoppe commented May 19, 2020

@ekohl My request was related to Puppet 5, but we all figured out that Puppet Inc. will not provide any Puppet 5 packages for Ubuntu 20.04.

@dhoppe dhoppe merged commit 101cb49 into voxpupuli:master May 19, 2020
@mmoll mmoll deleted the ubu20 branch May 19, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants