Support Debian 11 #415
Support Debian 11 #415
Conversation
|
Looks like it fails on installing bolt because the package is not available. I couldn't find an issue on https://tickets.puppet.com but that may just be my limited JIRA search skills. |
Yea, there isn't a Puppet Server package as well. Let's give them some time 😄 |
Signed-off-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
| @@ -16,13 +16,19 @@ | |||
| $pid_file = '/var/run/redis/redis-server.pid' | |||
| $workdir = '/var/lib/redis' | |||
| $bin_path = '/usr/bin' | |||
| $daemonize = true | |||
| $daemonize = $facts['os']['distro']['codename'] ? { | |||
There was a problem hiding this comment.
I'm generally not a fan of using the codename fact. It's generally not forward compatible. Can we deal with this similar to $sentinel_pid_file below?
| $sentinel_daemonize = $facts['os']['distro']['codename'] ? { | ||
| 'bullseye' => false, | ||
| default => true, | ||
| } |
There was a problem hiding this comment.
| $sentinel_daemonize = $facts['os']['distro']['codename'] ? { | |
| 'bullseye' => false, | |
| default => true, | |
| } | |
| $sentinel_daemonize = $daemonize, |
|
The problem with this PR seems to be deeper, that's why I haven't progress it further. For example Setting |
|
My ideal goal for this module was to leverage instances of # dpkg -L redis-server | grep .service
/lib/systemd/system/redis-server.service
/lib/systemd/system/redis-server@.serviceIt's not shipped on Debian 9, but we can drop Debian 9 support now that it's only maintained as LTS (as opposed to the Debian project itself). Then we would get out of the business of managing systemd files. An additional benefit is that you would get the security hardening that's in place. Sadly on Red Hat-based distros this isn't shipped. That can be solved by shipping a The migration may also be complex so I never got around to it, but that's the vision I had. We should probably write it down in an issue. |
|
I don't see those systemd files shipped on my Ubuntu 20.04 boxes. Also dunno how flexible is that when you want to run multiple redis servers on the same box. |
That's odd because I just installed redis-server on an Ubuntu 20.04 container and they were there. |
|
Should be there: https://packages.ubuntu.com/focal/amd64/redis-server/filelist |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues