Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Redis6 features #445

Merged
merged 1 commit into from Apr 20, 2022
Merged

Conversation

fraenki
Copy link
Member

@fraenki fraenki commented Apr 6, 2022

Pull Request (PR) description

This is basically a partial re-submission of PR #388 to add Redis 6 options.

However, there are some notable differences to the original submission:

  • this time with backwards compatibility in mind
  • not duplicating the redis.conf template and tests
  • and without any refactoring (to keep the diff as small as possible)

This Pull Request (PR) fixes the following issues

@fraenki fraenki force-pushed the redis6_params branch 3 times, most recently from f93d2d2 to a99fca2 Compare April 6, 2022 08:48
@fraenki fraenki force-pushed the redis6_params branch 5 times, most recently from 98f5f01 to 3a8918a Compare April 6, 2022 10:57
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks for the PR! I will keep this open for a few days in case someone else want's to review this as well (I'm not a redis expert).

@root-expert root-expert added the enhancement New feature or request label Apr 20, 2022
@root-expert root-expert merged commit 8ca9262 into voxpupuli:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants