Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add param to pass to apt-key adv #466

Merged
merged 6 commits into from Feb 15, 2023
Merged

Add param to pass to apt-key adv #466

merged 6 commits into from Feb 15, 2023

Conversation

pwf
Copy link
Contributor

@pwf pwf commented Feb 15, 2023

Pull Request (PR) description

Add param to pass to apt-key adv, http_proxy for an instance

ekohl
ekohl reviewed Feb 15, 2023
View reviewed changes
manifests/preinstall.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@pwf
Copy link
Contributor Author

pwf commented Feb 15, 2023

What should I need to fix/write to make this pipeline successful?

@ekohl
Copy link
Member

ekohl commented Feb 15, 2023

It looks like it considers the reference outdated. Usually this is solved by running strings:generate:reference (which generates REFERENCE.md. I just ran that and it adds the replicaof parameter, so 35be44b broke it.

@ekohl ekohl added the enhancement New feature or request label Feb 15, 2023
@ekohl ekohl merged commit 9881323 into voxpupuli:master Feb 15, 2023
@ekohl
Copy link
Member

ekohl commented Feb 15, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pwf @ekohl