Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deferrables for masterauth & requirepass #476

Merged
merged 2 commits into from Jun 1, 2023

Conversation

ThiefMaster
Copy link
Contributor

This allows getting the redis password (and/or master password) from an external secret storage using Puppet's Deferred mechanism.

I don't know if there's some way to use epp() in case deferrable_epp() doesn't exist in order to avoid bumping the stdlib requirement...

closes #473

@ThiefMaster ThiefMaster force-pushed the deferrable branch 3 times, most recently from 74d0910 to 004b283 Compare May 30, 2023 14:43
@alexjfisher
Copy link
Member

What version of Puppet are you using? From what I've read, this shouldn't be required since Puppet 7.17??

Remove compiler errors for deferred function mismatched types
Before, it was not possible to compile a catalog that used a Deferred value for a typed parameter class. The compiler would give an error message stating that the type expected did not match Deferred. Now, the compiler inspects the Deferred class's return type and ensures it matches the class parameter type. If the Deferred function has no return type, the compiler warns that it cannot guarantee whether the type adheres to the type the class specifies

See https://tickets.puppetlabs.com/browse/PUP-11518

But... I've not tried yet and perhaps there are still some issues.

@traylenator
Copy link
Contributor

Using 7.12 at this environment - it is indeed time we upgraded.

@ThiefMaster
Copy link
Contributor Author

In any case, even without the type requirement failing, I think the deferrable_epp() is required for it to work.

@ghoneycutt ghoneycutt merged commit 3be3221 into voxpupuli:master Jun 1, 2023
10 checks passed
@ThiefMaster ThiefMaster deleted the deferrable branch October 13, 2023 13:26
cegeka-jenkins pushed a commit to cegeka/puppet-redis that referenced this pull request Feb 26, 2024
Allow deferrables for masterauth & requirepass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deferred values for requirepass
4 participants