Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy Debian 10 / Ubuntu 18.04 / CentOS 7 #504

Merged
merged 1 commit into from Feb 16, 2024

Conversation

rwaffen
Copy link
Sponsor Member

@rwaffen rwaffen commented Feb 16, 2024

No description provided.

@bastelfreak bastelfreak changed the title remove legacy os'es remove legacy Debian 10 / Ubuntu 18.04 / CentOS 7 Feb 16, 2024
@rwaffen rwaffen merged commit 4fdf5ec into voxpupuli:master Feb 16, 2024
20 checks passed
@rwaffen rwaffen deleted the remove_legacy_os branch February 16, 2024 10:36
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party, but if you drop these in a major version then please also clean up teh code. For example, dropping EL 7 means you can also drop all the SCL stuff, including parameters.

if $facts['os']['family'] == 'RedHat' and versioncmp($facts['os']['release']['major'], '7') <= 0 {
if $redis::scl {
if $facts['os']['name'] == 'CentOS' {
ensure_packages(['centos-release-scl-rh'])
Package['centos-release-scl-rh'] -> Package[$redis::package_name]
}
} else {
require 'epel'
}

Edit: #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants