Allow the user/pw or org/key to be Deferred. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for merging my other PR. Any idea if this one can be merged as well while you are working in this repo? |
kenyon
reviewed
Dec 19, 2023
This introduces conditional logic to detect if sensitive/secret values may be passed in as Deferred type, and if so to process them entirely through a chain of Deferred arguments, to address issues with interpolating Deferred into strings on the compiler. Unfortunately, there is no way at the moment to pass a parameter of type Deferred into puppet-rspec, so while this has been tested and verified locally, there is not currently a unit test for this new functionality.
|
Rebased this PR and took @kenyon suggestion through the whole file re: variable reuse. Thanks for the tip, I knew you could do that in ruby but didn't realize it worked in puppet manifests. |
kenyon
approved these changes
Dec 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This introduces conditional logic to detect if sensitive/secret values may be passed in as Deferred type, and if so to process them entirely through a chain of Deferred arguments, to address issues with interpolating Deferred into strings on the compiler.
Unfortunately, there is no way at the moment to pass a parameter of type Deferred into puppet-rspec, so while this has been tested and verified locally, there is not currently a unit test for this new functionality.
This Pull Request (PR) fixes the following issues
n/a