Cyclic dependency

[negast]

Hello
I'm getting cyclic dependency issues when doing a new install (RHEL7).

I copied the yaml file from the example:

rsyslog::client::global_config:
  FileOwner:
    value: 'root'
    type: legacy
 ......
rsyslog::client::modules:
    imuxsock: {}
    imklog: {}
    
rsyslog::client::legacy_config:
  auth_priv_rule:
    key: "auth,authpriv.*"
    value: "/var/log/auth.log"
    .....

In my profiles I included the following

include rsyslog::client

When running on the node It gave me the following:

Error: Found 1 dependency cycle:
(Concat_file[/etc/rsyslog.d/50_rsyslog.conf] => Concat[/etc/rsyslog.d/50_rsyslog.conf] => Rsyslog::Generate_concat[rsyslog::concat::module::imuxsock] => Concat::Fragment[rsyslog::component::module::imuxsock] => Concat_fragment[rsyslog::component::module::imuxsock] => Concat_file[/etc/rsyslog.d/50_rsyslog.conf])\nCycle graph written to /opt/puppetlabs/puppet/cache/state/graphs/cycles.dot.
Error: Failed to apply catalog: One or more resource dependency cycles detected in graph

Here is the .dot file content

digraph Resource_Cycles {
  label = "Resource Cycles"
"Concat_file[/etc/rsyslog.d/50_rsyslog.conf]" -> "File[/etc/rsyslog.d/50_rsyslog.conf]" -> "Concat[/etc/rsyslog.d/50_rsyslog.conf]" -> "Rsyslog::Generate_concat[rsyslog::concat::module::imuxsock]" -> "Concat::Fragment[rsyslog::component::module::imuxsock]" -> "Concat_fragment[rsyslog::component::module::imuxsock]" -> "Concat_file[/etc/rsyslog.d/50_rsyslog.conf]"
"Concat_file[/etc/rsyslog.d/50_rsyslog.conf]" -> "Concat[/etc/rsyslog.d/50_rsyslog.conf]" -> "Rsyslog::Generate_concat[rsyslog::concat::module::imuxsock]" -> "Concat::Fragment[rsyslog::component::module::imuxsock]" -> "Concat_fragment[rsyslog::component::module::imuxsock]" -> "Concat_file[/etc/rsyslog.d/50_rsyslog.conf]"
}

I fixed this by removing the before statement from the component/module.pp file
/rsyslog/manifests/component/module.pp line 21

rsyslog::generate_concat { "rsyslog::concat::module::${name}":
    confdir => $confdir,
    target  => $target,
   (-)  before  => Concat::Fragment["rsyslog::component::module::${name}"],
  }

[dhollinger]

Going to take a deeper look at this and ensure this isn't a larger issue. What version of puppet are you on?

[negast]

I'm running version 5.5.1

[negast]

I have the same issue on custom config

 rsyslog::generate_concat { "rsyslog::concat::custom_config::${name}":
    confdir => $confdir,
    target  => $target,
    before  => Concat::Fragment["rsyslog::component::custom_config::${name}"],
  }

[dhollinger]

I have been unable to reproduce the issue in any environment.

[negast]

It seems It was due to an out of date concat and stdlib combo. After I also upgraded those I got an error related to this ticket: https://tickets.puppetlabs.com/browse/MODULES-5802
which I resolved by doing the generate types command: https://puppet.com/docs/puppet/6.10/environment_isolation.html

I'll close this then as it is no longer an issue. Thank you for the help.