Add ability to modify conf file and directory permissions #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdwhited could you review as well? |
bastelfreak
reviewed
May 23, 2020
bastelfreak
reviewed
May 23, 2020
dhollinger
force-pushed
the
set_permissions
branch
from
b4d83d5
to
5851dea
Compare
bastelfreak
approved these changes
May 23, 2020
| Integer $ruleset_priority, | ||
| Integer $filter_priority, | ||
| String $target_file, | ||
| Stdlib::Filemode $conf_permissions = '0644', |
There was a problem hiding this comment.
could be reduce by one whitespace
|
Thanks for working on this! Can you allow perms for /etc/rsyslog.conf as well? The other 2 look good. |
Added |
binford2k
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add the ability to configure the file and directory permissions for generated configuration files and the confdir.
This Pull Request (PR) fixes the following issues
Fixes #150