Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #76 breaks due to incomplete "framework_config" #100

Closed
wcooley opened this issue Jun 2, 2015 · 1 comment
Closed

PR #76 breaks due to incomplete "framework_config" #100

wcooley opened this issue Jun 2, 2015 · 1 comment

Comments

@wcooley
Copy link
Contributor

wcooley commented Jun 2, 2015

@grafjo There is a problem with PR #76 in that it misses the deep_merge that happens in rundeck::config, which merges the framework_config parameter from rundeck and rundeck::params::framework_config. I haven't had time to test if just inserting config:: is sufficient or not.

class { '::rundeck':
   ...
  framework_config => {
    'framework.server.port' => '8008',
    'framework.server.url' => 'https://rundeck.example.com',
  },
}
err: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid relationship: File[/admin.aclpolicy] { require => File[undef] }, because File[undef] doesn't seem to be in the catalog
@grafjo
Copy link
Contributor

grafjo commented Jun 2, 2015

Good point. My testing config is like this one:

class { 'rundeck':
  jre_manage => false,
  framework_config => {
    'framework.server.name'     => '127.0.0.1',
    'framework.server.hostname' => '127.0.0.1',
    'framework.server.port'     => '4440',
    'framework.server.url'      => "http://127.0.0.1:4440",
    'framework.server.username' => 'user',
    'framework.server.password' => 'password',
    'rdeck.base'                => '/var/lib/rundeck',
    'framework.projects.dir'    => '/var/rundeck/projects',
    'framework.etc.dir'         => '/etc/rundeck',
    'framework.var.dir'         => '/var/lib/rundeck/var',
    'framework.tmp.dir'         => '/var/lib/rundeck/var/tmp',
    'framework.logs.dir'        => '/var/lib/rundeck/logs',
    'framework.libext.dir'      => '/var/lib/rundeck/libext',
    'framework.ssh.keypath'     => '/var/lib/rundeck/.ssh/id_rsa',
    'framework.ssh.user'        => 'rundeck',
    'framework.ssh.timeout'     => '0',
    'rundeck.server.uuid'       => $::serialnumber,
  },

I'll look for a working solution

grafjo pushed a commit to grafjo/puppet-rundeck that referenced this issue Jun 2, 2015
liamjbennett added a commit that referenced this issue Jun 5, 2015
Updated the parameter defaults to fixed values not inherited from the
root rundeck class because it avoids any issues if the define is used on
it's own (not sure why you would do that) and also allows me to write a
test for the default case of the properties.dir setting.

Due to the above change I also update the config.pp file accordingly to
pass-through the remaining parameters.
liamjbennett pushed a commit that referenced this issue Jun 5, 2015
Fix for #100 deep merging issue with aclpolicyfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants