Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensitive option for database_config #482

Closed
Joris29 opened this issue Jan 11, 2022 · 5 comments · Fixed by #503
Closed

Add sensitive option for database_config #482

Joris29 opened this issue Jan 11, 2022 · 5 comments · Fixed by #503

Comments

@Joris29
Copy link
Contributor

Joris29 commented Jan 11, 2022

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.25.1
  • Ruby: 2.5.9p229
  • Distribution: RHEL 8
  • Module version: v6.0.0

How to reproduce (e.g Puppet code you use)

database_config => {
'type' => 'postgresql',
'url' => "jdbc:postgresql://${db_host}/${_servername}",
'username' => $db_username,
'password' => $db_password.unwrap,
'driverClassName' => 'org.postgresql.Driver',
},

What are you seeing

Notice: /Stage[main]/Rundeck::Config::Global::Rundeck_config/File[/etc/rundeck/rundeck-config.groovy]/content:
--- /etc/rundeck/rundeck-config.groovy 2022-01-11 09:02:27.648577738 +0100
+++ /tmp/puppet-file20220111-42398-1beilhv 2022-01-11 09:06:00.912297639 +0100
@@ -12,7 +12,7 @@
url = "jdbc:postgresql://localhost/rundeck"
driverClassName = "org.postgresql.Driver"
username = "my_user"
'-' password = "my_pass"
'+' password = "my_password"
dialect = ""
}

What behaviour did you expect instead

Notice: /Stage[main]/Rundeck::Config::Global::Rundeck_config/File[/etc/rundeck/rundeck-config.groovy]/content: value [redacted]

Output log

Any additional information you'd like to impart

@root-expert
Copy link
Member

Hello @Joris29 , can you provide a PR to address this issue?

@Joris29
Copy link
Contributor Author

Joris29 commented Jan 17, 2022

It was more like a request but i'll check if i can provide a PR for it

@Joris29
Copy link
Contributor Author

Joris29 commented Sep 9, 2022

@root-expert could you take a look at the PR?

@nosrio
Copy link
Contributor

nosrio commented Aug 7, 2023

Hi! Could someone please review my PR? Regards

@Joris29
Copy link
Contributor Author

Joris29 commented Aug 9, 2023

@bastelfreak Could someone pls look into this, the issue has be open for quite some time multiple solutions have been provided but no feedback so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment