New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sensitive for rundeck-config.groovy #493

Closed

phaedriel wants to merge 2 commits into voxpupuli:master from phaedriel:sensitive-config

Contributor

phaedriel commented Jan 7, 2023

Pull Request (PR) description

This PR fixes that credentials would be shown in puppet log if they change
This PR contains some minor corrections
- [warn]: The @param tag for parameter 'properties_dir' has no matching parameter at manifests/init.pp:224.
- [warn]: The @param tag for parameter 'rdeck_base' has no matching parameter at manifests/init.pp:224.
- [warn]: The @param tag for parameter 'projects_dir' has no matching parameter at manifests/config/resource_source.pp:80.
- [warn]: Missing documentation for Puppet type alias 'Rundeck::Loglevel' at types/loglevel.pp:1.
- [warn]: Missing documentation for Puppet type alias 'Rundeck::Sourcetype' at types/sourcetype.pp:1.

This Pull Request (PR) fixes the following issues

Fixes Add sensitive option for database_config #482
Finish PR Add sensitive for rundeck config #485


          Sensitive content rundeck-config.groovy

5be3bfd

phaedriel mentioned this pull request

Add sensitive for rundeck-config.groovy (rebase issue) #489

Closed

Contributor

Joris29 commented Oct 20, 2023

Any update on this because it's still leaking changes to puppet logs? @phaedriel


          Merge branch 'master' into sensitive-config

0e56ea5

phaedriel closed this

Contributor Author

phaedriel commented Oct 24, 2023

Any update on this because it's still leaking changes to puppet logs? @phaedriel

I closed the PR. The tests no longer pass

phaedriel deleted the sensitive-config branch

May 4, 2024 15:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment