Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ${pd} variable to replace /var/lib/rundeck/libext, if not default value #79

Closed
ozbillwang opened this issue May 26, 2015 · 2 comments
Labels
bug Something isn't working

Comments

@ozbillwang
Copy link
Contributor

Hi

Find this issue when change default plugin directory, and the unless command ls + grep can be merged into one ls command.

Change plugin.pp from:

unless  => "/bin/ls -l /var/lib/rundeck/libext/ | grep ${name}"

to

unless  => "/bin/ls ${pd}/${name} 2>/dev/null"

the change has been tested with updated code.

Debug: Exec[download plugin rundeck-ec2-nodes-plugin-1.5.jar](provider=posix): Executing check '/bin/ls /var/lib/rundeck/libext/rundeck-ec2-nodes-plugin-1.5.jar 2>/dev/null'
Debug: Executing '/bin/ls /var/lib/rundeck/libext/rundeck-ec2-nodes-plugin-1.5.jar 2>/dev/null'
Debug: /Stage[main]/Role::Rundeck/Rundeck::Config::Plugin[rundeck-ec2-nodes-plugin]/Exec[download plugin rundeck-ec2-nodes-plugin-1.5.jar]/unless: /var/lib/rundeck/libext/rundeck-ec2-nodes-plugin-1.5.jar
@ozbillwang ozbillwang changed the title use ${pd} variable to replace /var/lib/rundeck/libext, if not default value use ${pd} variable to replace /var/lib/rundeck/libext, if not default value May 26, 2015
ozbillwang added a commit to ozbillwang/puppet-rundeck that referenced this issue May 26, 2015
@ozbillwang
Copy link
Contributor Author

Pull request has been raised #80

@liamjbennett liamjbennett added the bug Something isn't working label May 29, 2015
@liamjbennett
Copy link
Member

This issue should now have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants