fixing spec tests #180
Merged
fixing spec tests #180
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had some of this in a PR I have open, but it's good to get it done here. |
liamjbennett
force-pushed
the
fix_tests
branch
3 times, most recently
from
84ed01f
to
881070b
Compare
| if !$content_size { | ||
| $content_size_value = size($value) | ||
| } | ||
|
|
There was a problem hiding this comment.
Should there be an else here, setting $content_size_value to $content_size?
liamjbennett
force-pushed
the
fix_tests
branch
from
881070b
to
dbe59cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.