Add required Vault api version to template #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wer Vault installations
|
This looks good, just needs a test. This could be a one liner that tests that the contents of the template are rendered correctly. Have a look at https://github.com/voxpupuli/puppet-rundeck/blob/523a03cca67d681254c8c8b5c738e12a5c172eb9/spec/classes/config/global/rundeck_config_spec.rb for examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In the PR for #430, the API version was missing. For newer installation we have to set it to "2", which should be default for the Vault plugin anyway, but is seems, that this is not the case, so we have to set it explicit, otherwise we get "permission denied" messages in the Vault access logs.