Inisettings resolve deprecation: use namespaced create_ini_settings function
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inifile 4.1 adds inifile::create_ini_settings, and version 4.2 deprecates the non-namespace version: ``` DEPRECATED. Use the namespaced function inifile::create_ini_settings instead. ``` https://forge.puppet.com/modules/puppetlabs/inifile/4.2.0/reference#create_ini_settings
In order to support inifile greater than 4.2, we have to change from create_ini_settings to inifile::create_ini_settings (which was introduced in 4.1.0), so 4.1.0 would become the minimal supported version.
kenyon
changed the title
kenyon
changed the title
create_ini_settings function
kenyon
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Change the (now deprecated) create_ini_settings function to its namespaced alternative inifile::create_ini_settings and increase the minimal supported version of inifile dependency, to the first version where inifile::create_ini_settings was introduced.
This Pull Request (PR) fixes the following issues
Fixes #496