Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert documentation to Puppet Strings format #519

Merged
merged 14 commits into from Nov 8, 2023

Conversation

Joris29
Copy link
Contributor

@Joris29 Joris29 commented Nov 7, 2023

Pull Request (PR) description

Update documentation and generate reference with puppet strings.

This Pull Request (PR) fixes the following issues

Followup to #516.

@Joris29
Copy link
Contributor Author

Joris29 commented Nov 7, 2023

@kenyon Hello so i took my time to go trough all documentation and added missing docs or update docs to be able to generate reference with puppet strings.

The reference was generated but the report is not 100% yet and i also need to remove stuff from the readme but i wanted your view on why the puppet strings is not yet at 100%.

This is the report:

[vacoj@lx-20202056 puppet-rundeck]$ puppet strings generate --format markdown
[warn]: Missing @return tag near lib/puppet/parser/functions/validate_rd_policy.rb:9.
Files                     21
Modules                   3 (1 undocumented)
Classes                   1 (0 undocumented)
Constants                 0 (0 undocumented)
Attributes                0 (0 undocumented)
Methods                   10 (9 undocumented)
Puppet Classes            11 (0 undocumented)
Puppet Data Types         0 (0 undocumented)
Puppet Data Type Aliases  2 (0 undocumented)
Puppet Defined Types      6 (0 undocumented)
Puppet Providers          0 (0 undocumented)
Puppet Functions          1 (0 undocumented)
Puppet Tasks              0 (0 undocumented)
Puppet Plans              0 (0 undocumented)
Puppet Types              0 (0 undocumented)
 70.59% documented

@kenyon
Copy link
Member

kenyon commented Nov 7, 2023

Nice work!

I think the Modules line is about Ruby modules, like here:

Same for Methods, I think it is referring to the Ruby methods in acl.rb being undocumented. I think we can ignore that for now.

By the way, you can do bundle install and then bundle exec rake strings:generate:reference to generate REFERENCE.md.

@kenyon kenyon changed the title Update module documentation Convert documentation to Puppet Strings format Nov 7, 2023
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the Setup and Reference sections from the README.

@kenyon kenyon added the docs Improvements or additions to documentation label Nov 7, 2023
@Joris29
Copy link
Contributor Author

Joris29 commented Nov 8, 2023

@kenyon I generated the refs with the command provided but same result I guess we can ignore it for now.

[vacoj@lx-20202056 puppet-rundeck]$ bundle exec rake strings:generate:reference
[warn]: Missing @return tag near lib/puppet/parser/functions/validate_rd_policy.rb:9.
Files                     21
Modules                   3 (1 undocumented)
Classes                   1 (0 undocumented)
Constants                 0 (0 undocumented)
Attributes                0 (0 undocumented)
Methods                   10 (9 undocumented)
Puppet Classes            11 (0 undocumented)
Puppet Data Type Aliases  2 (0 undocumented)
Puppet Data Types         0 (0 undocumented)
Puppet Types              0 (0 undocumented)
Puppet Defined Types      6 (0 undocumented)
Puppet Functions          1 (0 undocumented)
Puppet Plans              0 (0 undocumented)
Puppet Providers          0 (0 undocumented)
Puppet Tasks              0 (0 undocumented)
 70.59% documented

I also updated the readme properly and moved the examples to the readme.

Do you want me to squash all commits into one or should i reword some commits or is it fine like it is now?

@Joris29 Joris29 marked this pull request as ready for review November 8, 2023 17:23
@Joris29 Joris29 requested a review from kenyon November 8, 2023 20:42
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks. I will do a squash on merge.

@kenyon kenyon merged commit f6fcd7c into voxpupuli:master Nov 8, 2023
32 checks passed
@Joris29 Joris29 deleted the module_quality branch November 8, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants