fix rubocop warnings

lib/puppet/provider/rvm_gem/gem.rb

@@ -107,12 +107,10 @@ def install(useversion = true)
         # interpret it as a gem repository
         command << '--source' << source.to_s << resource[:name]
       end
+    elsif Gem::Version.new(rubygems_version) < Gem::Version.new('3.0.0')
+      command << '--no-rdoc' << '--no-ri' << resource[:name] # Deprecated options (backwards compatible)
     else
-      if Gem::Version.new(rubygems_version) < Gem::Version.new('3.0.0')
-        command << '--no-rdoc' << '--no-ri' << resource[:name] # Deprecated options (backwards compatible)
-      else
-        command << '--no-document' << resource[:name]
-      end
+      command << '--no-document' << resource[:name]
     end
 
     # makefile opts,

lib/puppet/type/rvm_gem.rb

@@ -2,7 +2,7 @@
   @doc = 'Ruby Gem support using RVM.'
 
   def self.title_patterns
-    [[/^(?:(.*)\/)?(.*)$/, [[:ruby_version, ->(x) { x }], [:name, ->(x) { x }]]]]
+    [[/^(?:(.*)\/)?(.*)$/, [[:ruby_version, ->(x) { x }], [:name, ->(x) { x }]]]] # rubocop:disable Style/RegexpLiteral
   end
 
   ensurable do

spec/acceptance/rvm_system_spec.rb

@@ -269,7 +269,7 @@ class { 'rvm::passenger::apache':
 
     it 'answers' do
       shell('/usr/bin/curl localhost:80') do |r|
-        r.stdout.should =~ /^hello <b>world<\/b>$/
+        r.stdout.should =~ %r{^hello <b>world</b>$}
         r.exit_code.should == 0
       end
     end
@@ -376,7 +376,7 @@ class { 'rvm::passenger::apache':
 
     it 'answers' do
       shell('/usr/bin/curl localhost:80') do |r|
-        r.stdout.should =~ /^hello <b>world<\/b>$/
+        r.stdout.should =~ %r{^hello <b>world</b>$}
         r.exit_code.should == 0
       end
     end
@@ -390,7 +390,7 @@ class { 'rvm::passenger::apache':
         r.stdout.should =~ %r{Requests in top\-level queue \: [0-9]+}
         r.stdout.should =~ %r{[\-]+ Application groups [\-]+}
         # the following will only appear after a request has been made, as in "should answer to" above
-        r.stdout.should =~ /App root\: \/var\/www\/passenger/
+        r.stdout.should =~ %r{App root: /var/www/passenger}
         r.stdout.should =~ %r{Requests in queue\: [0-9]+}
         r.exit_code.should == 0
       end

spec/classes/dependencies_spec.rb

@@ -17,7 +17,7 @@
         case os_facts[:operatingsystemmajrelease]
         when '5'
           if %w[CentOS RedHat].include? os_facts[:operatingsystem]
-            it { is_expected.to contain_package('autoconf') }
+            it { is_expected.to contain_package('autoconf') } # rubocop:disable RSpec/RepeatedExample
             it { is_expected.to contain_package('curl-devel') }
             it { is_expected.not_to contain_package('libcurl-devel') }
           end
@@ -27,7 +27,7 @@
           it { is_expected.not_to contain_package('curl-devel') }
         end
       when 'Debian'
-        it { is_expected.to contain_package('autoconf') }
+        it { is_expected.to contain_package('autoconf') } # rubocop:disable RSpec/RepeatedExample
         it { is_expected.to contain_package('build-essential') }
         it { is_expected.not_to contain_package('which') }
         it { is_expected.not_to contain_package('gcc') }

spec/classes/system_spec.rb

@@ -8,7 +8,7 @@
       root_home: '/root',
       osfamily: 'Debian',
       os: {
-        family: 'Debian',
+        family: 'Debian'
       }
     }
   end

spec/spec_helper_acceptance.rb

@@ -21,7 +21,7 @@ def install_puppet(host)
   # Project root
   proj_root = File.expand_path(File.join(File.dirname(__FILE__), '..'))
 
-  c.before(:each) do
+  c.before do
     Puppet::Util::Log.level = :warning
     Puppet::Util::Log.newdestination(:console)
   end