Default module prefix now '' #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With RHEL7.3 the default module prefix causes problems
in particular the following happens
with
```puppet
selinux::module { 'openshift-cvmfs':
ensure => present,
source => 'puppet:///modules/hg_paas/openshift-cvmfs.te',
}
```
```
Compiling targeted local_openshift-cvmfs module
/usr/bin/checkmodule: loading policy configuration from
tmp/local_openshift-cvmfs.tmp
/usr/bin/checkmodule: Module name openshift-cvmfs is different than the
output base filename local_openshift-cvmfs
make: *** [tmp/local_openshift-cvmfs.mod] Error 1
```
As far as I can ascertain the prefix only influences the file name
and actual module name comes from what's inside the policy file.
Anyone testing this may well runinto another selinux bug that
is not a problem of this module.
* [CERN ticket reference](https://its.cern.ch/jira/browse/AI-4745)
* [Change in checkmodule](SELinuxProject/selinux@c6acfae#diff-9a0edd4c660062ff41e43d787595141d)
* [puppet problem](https://bugzilla.redhat.com/show_bug.cgi?id=1391886)
* [selinux bug](https://bugzilla.redhat.com/show_bug.cgi?id=1395222)
|
There is another option to remove the prefix parameter. I think it should actually never be set. |
|
@traylenator either way defaulting to unset or removing it at all is a breaking change for existing users. My vote to remove it completly. |
|
Thanks @traylenator! I think keeping it for now is the better approach. |
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
Default module prefix now ''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With RHEL7.3 the default module prefix causes problems
in particular the following happens
with
As far as I can ascertain the prefix only influences the file name
and actual module name comes from what's inside the policy file.
Anyone testing this may well runinto another selinux bug that
is not a problem of this module.