selinux::login: Miscellaneous fixes #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll mark this as WIP until I've fixed the CI issues |
EmRowlands
force-pushed
the
selinux_login_fix
branch
3 times, most recently
from
27f22f5
to
30d5396
Compare
bastelfreak
reviewed
Apr 13, 2023
EmRowlands
force-pushed
the
selinux_login_fix
branch
from
30d5396
to
d1c1cdb
Compare
EmRowlands
force-pushed
the
selinux_login_fix
branch
from
d1c1cdb
to
023ff7e
Compare
This commit adds the source of the login mapping to the helper script. Helper script comments are also updated, as well as some additional error checking added.
This commit will correctly set the "title" property. Without this, when
using the Resources resource as below, an error will occur due to title
being absent.
resources {
'selinux_login':
purge => true
}
This allows for resources to be named consistently when the properties change.
This allows for the login configuration to be updated, and not just created and removed.
EmRowlands
force-pushed
the
selinux_login_fix
branch
from
023ff7e
to
a99009c
Compare
|
This is now fully rebased onto master, and is ready for re-review. |
kenyon
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR provides a small number of fixes for the
selinux::logindefined resource, including:This Pull Request (PR) fixes the following issues
n/a