Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate documentation to Puppet strings #70

Merged
merged 1 commit into from Jul 22, 2021
Merged

Migrate documentation to Puppet strings #70

merged 1 commit into from Jul 22, 2021

Conversation

nod0n
Copy link
Contributor

@nod0n nod0n commented Apr 13, 2021

Pull Request (PR) description

Replace class and define documentation with puppet strings type documentation.

@nod0n nod0n mentioned this pull request Apr 13, 2021
Closed
@nod0n nod0n changed the title WIP puppet strings (first try) puppet strings Apr 14, 2021
@nod0n nod0n marked this pull request as ready for review April 14, 2021 12:48
@nod0n nod0n mentioned this pull request Apr 19, 2021
Closed
@oranenj oranenj changed the title puppet strings Migrate documenation to Puppet strings Apr 19, 2021
oranenj
oranenj approved these changes Apr 19, 2021
View reviewed changes
Copy link

@oranenj oranenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to read 100% through all of this, but since it's only documentation changes and I can't spot anything wrong, I'll trust that it's fine.

@oranenj oranenj changed the title Migrate documenation to Puppet strings Migrate documentation to Puppet strings Apr 19, 2021
ekohl
ekohl requested changes Apr 19, 2021
View reviewed changes
docs/_index.html Outdated Show resolved Hide resolved
ekohl
ekohl approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be squashed. We can do it on merge, but we shouldn't forget that.

Do you want to add the @summary tag before we merge?

manifests/jail.pp Show resolved Hide resolved
igalic
igalic approved these changes Jul 22, 2021
View reviewed changes
Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

ekohl
ekohl reviewed Jul 22, 2021
View reviewed changes
REFERENCE.md Outdated Show resolved Hide resolved
ekohl
ekohl approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit f20243d into voxpupuli:master Jul 22, 2021
@nod0n nod0n deleted the docs branch July 22, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oranenj oranenj oranenj approved these changes

@ekohl ekohl ekohl approved these changes

@igalic igalic igalic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nod0n @oranenj @ekohl @igalic