Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables 'remark' and 'hierarchy_parent' should have defaults matching validation as strings. #74

Closed
seriv opened this issue Nov 10, 2017 · 1 comment · Fixed by #99

Comments

@seriv
Copy link
Contributor

seriv commented Nov 10, 2017

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.10.9
  • Ruby: that of puppet opensource
  • Distribution: opensource
  • Module version: master

How to reproduce (e.g Puppet code you use)

Try install on RHEL-7

What are you seeing

If variables remark and hierarchy_parent are not defined, module fails when validating these to be a string.

What behaviour did you expect instead

No errors.

Output log

Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Smokeping::Target[umiacs]: expects a value for parameter 'hierarchy_parent' expects a value for parameter 'remark' at /etc/puppetlabs/code/environments/smokeping/site/profile/manifests/smokeping/server.pp:32 on node netman.cs.umd.edu

Any additional information you'd like to impart

@seriv
Copy link
Contributor Author

seriv commented Nov 10, 2017

Should be fixed by #75

alexjfisher added a commit to alexjfisher/puppet-smokeping that referenced this issue Sep 14, 2018
fixes voxpupuli#74

voxpupuli#70 introduced a
regression.  Several parameters were made mandatory (previously they
defaulted to an empty string.)

They are now `Optional` and default to `undef`.
alexjfisher added a commit to alexjfisher/puppet-smokeping that referenced this issue Sep 14, 2018
fixes voxpupuli#74

voxpupuli#70 introduced a
regression.  Several parameters were made mandatory (previously they
defaulted to an empty string.)

They are now `Optional` and default to `undef`.
alexjfisher added a commit to alexjfisher/puppet-smokeping that referenced this issue Sep 14, 2018
fixes voxpupuli#74

voxpupuli#70 introduced a
regression.  Several parameters were made mandatory (previously they
defaulted to an empty string.)

They are now `Optional` and default to `undef`.

This is a breaking change as empty strings are no longer allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant