Configure slaves with systemd #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
slave-systemd
branch
8 times, most recently
from
bc1ac62
to
8defa21
Compare
|
@kenyon ping :) |
|
@bastelfreak well I am using this, so it works for me. Unfortunately I made so many changes that it's kind of hard to review. I'll at least try to rebase this and resolve conflicts tonight, and set it as ready for review. |
bastelfreak
approved these changes
Mar 16, 2022
kenyon
force-pushed
the
slave-systemd
branch
2 times, most recently
from
8fe51da
to
c718d05
Compare
With currently-supported OSes, smokeping uses systemd. The systemd service unit doesn't use /etc/default/smokeping at all. In order to run smokeping in slave mode, you have to use a systemd service unit dropin file. This commit also converts the slave template to EPP, corrects the data type of the slave_color parameter, and makes some code cleanups.
kenyon
force-pushed
the
slave-systemd
branch
from
c718d05
to
3dc6bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure smokeping in slave mode with a systemd dropin file. This is the way to configure smokeping slaves when using modern distribution packages.