Add option to manage imgcache directory #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Can you please combine your commits in a single one? From your working directory: This will bring your editor. Keep the first line unchanged, and replace Then push your updated branch: |
yakatz
force-pushed
the
bug/too_many_files
branch
from
2b32e31
to
c152dca
Compare
andybotting
added a commit
to NeCTAR-RC/puppet-smokeping
that referenced
this pull request
Feb 10, 2022
In a similar fashion to PR voxpupuli#146, also add a argument to prevent the management of the data dir. The scenario I ran into needing this was when using a master/slave setup. The remote data comes in via Apache with the www-data user and it requires a setfacl entry as documented at https://github.com/oetiker/SmokePing/wiki/FAQ#master-slave-setups or you'll see permission denied errors in the log file. Ideally this module would be extended to support master/slave better, but this will help in the meantime.
kenyon
changed the title
kenyon
force-pushed
the
bug/too_many_files
branch
from
c152dca
to
0b6219d
Compare
Possible workaround for voxpupuli#145
kenyon
force-pushed
the
bug/too_many_files
branch
from
0b6219d
to
c944f20
Compare
trice-ardc
added a commit
to NeCTAR-RC/puppet-smokeping
that referenced
this pull request
Mar 21, 2024
This should prevent the warning: > Warning: The directory '/var/cache/smokeping/images' contains 1027 entries, which exceeds the default soft limit 1000 and may cause excessive resource consumption and degraded performance. To remove this warning set a value for `max_files` parameter or consider using an alternate method to manage large directory trees Also see https://www.puppet.com/docs/puppet/7/types/file.html#file-attribute-max_files We may be able to revert this in v7.0.0, which introduces an option to not manage the image cache: * voxpupuli#145 * voxpupuli#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow not managing
imgcachedirectoryAdd more tests
This Pull Request (PR) fixes the following issues
Fixes #145