Add option for management of datadir #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kenyon
force-pushed
the
manage-datadir
branch
2 times, most recently
from
c93ec3c
to
617ba6e
Compare
kenyon
force-pushed
the
manage-datadir
branch
4 times, most recently
from
7918b5e
to
80b6bec
Compare
smortex
reviewed
Sep 4, 2023
This change adds a new manage_datadir argument to selectively prevent the management of the data dir. The scenario I ran into needing this was when using a master/slave setup. The remote data comes in via Apache with the www-data user and it requires a setfacl entry as documented at https://github.com/oetiker/SmokePing/wiki/FAQ#master-slave-setups or you'll see permission denied errors in the log file. Ideally this module would be extended to support master/slave better, but this will help in the meantime.
kenyon
force-pushed
the
manage-datadir
branch
from
66f0756
to
eae4ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #148.
Also contains #160 and #161.