use structured facts #154
use structured facts #154
Conversation
| operatingsystemrelease: '6.4', | ||
| lsbmajdistrelease: '6', | ||
| operatingsystemmajrelease: '6' | ||
| os: { 'release' => { 'full' => '6.4', 'major' => '6' }, 'name' => 'CentOS', 'family' => 'RedHat' } |
There was a problem hiding this comment.
How easy would it be to start using rspec-puppet-facts?
There was a problem hiding this comment.
Sure that tests with rspec-puppet-facts is better. But, before 4.0.0 is released i wished the module is with structured facts in its code.
If i have enough time before release, i will propose an other one about tests using rspec-puppet-facts. It is necessary to clean up some parts. I saw code/tests about old OSes.
For the moment, i propose to merge the PR as this.
There was a problem hiding this comment.
As long as the facts you've mocked are accurate and you've not just written them in such a way to make the tests pass! :)
There was a problem hiding this comment.
Excepted if i made an error, i reported same data but with structured facts instead of string facts
There was a problem hiding this comment.
Tests with rspec-puppet-facts will be done in a futur PR.
|
fyi, rspec-puppet-facts doesn't have these facts so it broke folks following master. For context, https://bugs.launchpad.net/tripleo/+bug/1800944 and we are using rspec-puppet-facts (https://github.com/openstack/puppet-tripleo/blob/master/spec/classes/tripleo_profile_base_snmp_spec.rb#L74-L81) |
|
@mwhahaha rspec-puppet-facts does have those facts, but only if you tell it to use facts from a version of facter >= 3. |
|
and here https://github.com/camptocamp/facterdb/tree/master/facts for versions available to rspec-puppet-facts |
Pull Request (PR) description
move out string facts to use structured facts.
This Pull Request (PR) fixes the following issues