Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip zero length strings in ERB template output #37

Closed
wants to merge 6 commits into from
Closed

skip zero length strings in ERB template output #37

wants to merge 6 commits into from

Conversation

bdellegrazie
Copy link

Ensure that rocommunity and friends can be explicitly disabled
by setting them to the empty string (not undefined).

Solves #36

@razorsedge razorsedge added the enhancement New feature or request label Mar 20, 2015
@razorsedge razorsedge self-assigned this Mar 20, 2015
@razorsedge
Copy link
Contributor

Would it be possible to resubmit this PR against razorsedge:develop?

@razorsedge razorsedge added bug Something isn't working and removed enhancement New feature or request labels Mar 20, 2015
@bdellegrazie
Copy link
Author

Hi Mike,

Sure, the only thing is it fails on Ruby 1.8.x (i.e. the template breaks).
Its pretty simple I just don't know how to solve the problem with the
earlier version of Ruby.
I'll get to it sometime this weekend.

Thanks,

Brett

On 20 March 2015 at 06:41, Mike Arnold notifications@github.com wrote:

Would it be possible to resubmit this PR against razorsedge:develop?

—
Reply to this email directly or view it on GitHub
#37 (comment).

Kind regards,

Brett Delle Grazie

@razorsedge
Copy link
Contributor

Possibly try .length instead of .size?

@razorsedge
Copy link
Contributor

Actually, strike that. The Travis failures are due to the use of rspec 3 on Ruby 1.8.7. I have fixed that error in razorsedge:develop.

@bdellegrazie
Copy link
Author

Cool, I'll rebase sometime this weekend.

Cheers,

Brett

On 20 March 2015 at 07:22, Mike Arnold notifications@github.com wrote:

Actually, strike that. The Travis failures are due to the use of rspec 3
on Ruby 1.8.7. I have fixed that error in razorsedge:develop.

—
Reply to this email directly or view it on GitHub
#37 (comment).

Kind regards,

Brett Delle Grazie

skip zero length strings in ERB template output
39beba4 
Ensure that rocommunity and friends can be explicitly disabled
by setting them to the empty string (not undefined).

Solves #36
@bdellegrazie
Copy link
Author

or now :)

On 20 March 2015 at 07:23, Brett Delle Grazie brett.dellegrazie@gmail.com
wrote:

Cool, I'll rebase sometime this weekend.

Cheers,

Brett

On 20 March 2015 at 07:22, Mike Arnold notifications@github.com wrote:

Actually, strike that. The Travis failures are due to the use of rspec 3
on Ruby 1.8.7. I have fixed that error in razorsedge:develop.

—
Reply to this email directly or view it on GitHub
#37 (comment)
.

Kind regards,

Brett Delle Grazie

Kind regards,

Brett Delle Grazie

@razorsedge
Copy link
Contributor

Rebasing makes things worse. :-( GitHub does not let you change the target. You will have to close this PR and submit a new one.

@bdellegrazie
Copy link
Author

Closing as requested, will reopen again

@bdellegrazie
Copy link
Author

Reopened as #41

@bdellegrazie bdellegrazie deleted the handle_empty_rocommunity branch March 24, 2015 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@razorsedge razorsedge

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdellegrazie @razorsedge