Windows fixes #234
Merged
Windows fixes #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 29, 2019 15:48
alexjfisher
reviewed
May 1, 2019
alexjfisher
reviewed
May 1, 2019
alexjfisher
reviewed
May 1, 2019
added 8 commits
May 1, 2019 15:05
alexjfisher
reviewed
May 2, 2019
alexjfisher
reviewed
May 2, 2019
bastelfreak
reviewed
May 2, 2019
bastelfreak
reviewed
May 2, 2019
bastelfreak
added
needs-tests
bug
Co-Authored-By: kreeuwijk <kevin.reeuwijk@puppet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides several fixes to ensure splunk::enterprise and splunk::forwarder works correctly for Windows and Linux.
It also ensures that the prerequisite net-tools package is not only ensured when needed, but that this is done before Splunk Enterprise/Forwarder is installed.