Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage the service #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bc-bjoern
Copy link

This pull request add the option service_ensure, to make it possible to stop the service in case.

@nick-markowski
Copy link
Contributor

@bc-bjoern Good idea, we should probably do the same with splunk enterprise. Would you mind updating the acceptance suite to toggle the ensure from running to stopped to test for validity? I can help if you'd like, let me know :)

@bc-bjoern
Copy link
Author

Hey, may you can help me out here.
This "["running", "stopped"]" doesn't work.

should contain Service[SplunkForwarder] with ensure => ["running", "stopped"], enable => true, status defined, restart defined, start defined and stop defined (FAILED - 1)

@nick-markowski
Copy link
Contributor

I'm doing a minor refactor to push params to moduledata, I'll incorporate this change with it and ping you when it's submitted for a PR

@bc-bjoern
Copy link
Author

Well okay, thank you!

@nick-markowski
Copy link
Contributor

#250

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants