Convert from Travis CI to GitHub Actions #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
gha
branch
4 times, most recently
from
f986fc9
to
aa30541
Compare
|
I do not know why the tests are failing. They pass locally for me. |
Closed
GitHub action install the bundle in the vendor directory in the project root. We want to ignore it.
|
I could reproduce the failure by running The remaining errors with Ruby 3.1 seems related to #129 |
bastelfreak
approved these changes
Apr 19, 2022
|
Looks like the patch in incompatible with Ruby < 2.6 |
Ruby 3.1 deprecates the old style, but Ruby < 2.6 doesn't accept the new style. This is compatible with both.
|
Now it's green. |
bastelfreak
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft because I need to figure out the test matrix. It should also add a release workflow.