Hiera: Test for wrong interpolation syntax #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
commented
Apr 4, 2023
bastelfreak
force-pushed
the
lookup
branch
6 times, most recently
from
d8c50be
to
73c82df
Compare
rwaffen
approved these changes
Mar 8, 2024
TheMeier
reviewed
Mar 8, 2024
TheMeier
reviewed
Mar 8, 2024
bastelfreak
force-pushed
the
lookup
branch
2 times, most recently
from
04cf85f
to
7d913b5
Compare
bastelfreak
commented
Mar 8, 2024
| end | ||
|
|
||
| # gets a hash or array, returns all keys + values as array | ||
| def flatten_data(data, parent_key = []) |
There was a problem hiding this comment.
this was written with the help of chatgpt
tuxmea
approved these changes
Mar 9, 2024
This commit adds new base functions to validate hiera *data*. Previously we only tested hiera *keys* and eyaml. This also adds one specific check, to validate the correct syntax for lookup function interpolation.
bastelfreak
added a commit
to bastelfreak/puppetlabs_spec_helper
that referenced
this pull request
Mar 12, 2024
This is a new option in puppet-syntax 4.1.0: voxpupuli/puppet-syntax#143 It will be enabled in puppet-syntax 5 be default: voxpupuli/puppet-syntax#167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new base functions to validate hiera data. Previously we only tested hiera keys and eyaml. This also adds one specific check, to validate the correct syntax for lookup function interpolation.