Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow WorkingDirectory to be specified in [Service] #352

Merged
merged 1 commit into from Jun 15, 2023
Merged

Allow WorkingDirectory to be specified in [Service] #352

merged 1 commit into from Jun 15, 2023

Conversation

traylenator
Copy link
Contributor

Pull Request (PR) description

Support use of WorkingDirectory directive in [Service] section of systemd::manage_unit and systemd::manage_dropin

https://www.freedesktop.org/software/systemd/man/systemd.exec.html#WorkingDirectory=

This Pull Request (PR) fixes the following issues

Fixes: #299

@traylenator traylenator added the enhancement New feature or request label Jun 15, 2023
@traylenator traylenator mentioned this pull request Jun 15, 2023
Merged
smortex
smortex approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fixing CI should be straightforward, and while here maybe we can put an explicit 0-sized string as minimum length.

REFERENCE.md Outdated Show resolved Hide resolved
spec/type_aliases/systemd_unit_service_spec.rb Outdated Show resolved Hide resolved
@traylenator
Allow WorkingDirectory to be specified in [Service]
c785f4f 
Support use of `WorkingDirectory` directive in `[Service]`
section of `systemd::manage_unit` and `systemd::manage_dropin`

https://www.freedesktop.org/software/systemd/man/systemd.exec.html#WorkingDirectory=

Fixes: voxpupuli#299
@ekohl
Copy link
Member

ekohl commented Jun 15, 2023 

Failure/Error: configure_beaker
RuntimeError:
  No repository installation step for archlinux yet...

So that's unrelated, but something we should fix.

@traylenator traylenator merged commit a9feee1 into voxpupuli:master Jun 15, 2023
16 of 17 checks passed
@traylenator traylenator deleted the workingdir branch June 15, 2023 09:06
@smortex
Copy link
Member

smortex commented Jun 15, 2023 

Failure/Error: configure_beaker
RuntimeError:
  No repository installation step for archlinux yet...

So that's unrelated, but something we should fix.

I opened this today: voxpupuli/beaker_puppet_helpers#31 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@ekohl ekohl ekohl approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Systemd::Unit::Service: missing User and Group
4 participants
@traylenator @ekohl @smortex @bastelfreak