systemd::unit_file: Ensure link gets removed on ensure => absent
#405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
approved these changes
Mar 6, 2024
kenyon
changed the title
ensure => absent
kenyon
changed the title
ensure => absentsystemd::unit_file: Ensure link gets removed on ensure => absent
kenyon
requested changes
Mar 7, 2024
baurmatt
force-pushed
the
unit_file_ensure_absent_link
branch
from
e300262
to
7f63dfa
Compare
kenyon
approved these changes
Mar 11, 2024
baurmatt
added a commit
that referenced
this pull request
Mar 11, 2024
@cocker-cc correctly mentioned in 7f63dfa#commitcomment-139614892 that after #405 `ensure=file` breaks due to `stdlib::ensure` not being able to handle that. As `file` is any way only a synonym for `present`, let's just remove it from the possible values.
baurmatt
added a commit
that referenced
this pull request
Mar 12, 2024
@cocker-cc correctly mentioned in 7f63dfa#commitcomment-139614892 that after #405 `ensure=file` breaks due to `stdlib::ensure` not being able to handle that. As `file` is any way only a synonym for `present`, let's just remove it from the possible values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Currently the
systemd::unit_filetype ignores theensureparameter iftargetis defined. This allows theensureparameter to be absent and thus removing the unit file iftargetis set.This Pull Request (PR) fixes the following issues