Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple Environment Settings #409

Merged
merged 1 commit into from Feb 2, 2024

Conversation

traylenator
Copy link
Contributor

Pull Request (PR) description

It was previously impossible to set more than one environment variable:

e.g.

systemd::manage_unit { 'test.service':
  unit_entry    => {
    'Description' => 'Bla',
  },
  service_entry => {
    'Type'        => 'oneshot',
    'Environment' => [
      'bla=foo',
      'bar=bla',
    ],
    'ExecStart'   => '/usr/bin/true',
  },
  enable        => false,
  active        => false,
}

This Pull Request (PR) fixes the following issues

Fixes #404

It was previously impossible to set more than one environment variable:

e.g.

```puppet
systemd::manage_unit { 'test.service':
  unit_entry    => {
    'Description' => 'Bla',
  },
  service_entry => {
    'Type'        => 'oneshot',
    'Environment' => [
      'bla=foo',
      'bar=bla',
    ],
    'ExecStart'   => '/usr/bin/true',
  },
  enable        => false,
  active        => false,
}
```

* Fixes voxpupuli#404
@traylenator traylenator added the bug Something isn't working label Feb 2, 2024
@moritzdietz
Copy link

Would you believe that I was just about to open a PR to fix this very thing? I wasn't expecting anyone to pay attention to this issue so quickly hah! Thanks for that

@ekohl
Copy link
Member

ekohl commented Feb 2, 2024

Test failure is unreadable on the mobile app, but I suspect it's the timeout again

@moritzdietz
Copy link

Test failure is unreadable on the mobile app, but I suspect it's the timeout again

Yup, the CI job says "read timeout reached" as the error message

@traylenator traylenator merged commit 197a307 into voxpupuli:master Feb 2, 2024
33 of 34 checks passed
@traylenator traylenator deleted the multienv branch February 2, 2024 12:34
@ekohl
Copy link
Member

ekohl commented Feb 2, 2024

I wonder why it happens so often. Perhaps it's quay.io that's unreliable. Maybe also beaker-docker that could do something smarter, like retry. Right now I don't even know where it exactly fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manage_unit service_entry Environment can't have multiple values
3 participants