Use Systemd::Unit::Amount, Percent and AmountOrPercent #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new types: * `Systemd::Unit::Amount` * `Systemd::Unit::Percent1` * `Systemd::Unit::AmountOrPercent` A few points to note: * While **some** documentation only mentions up to Tera the systemd code supports up to Peta and Exa. Some man pages are correct. * The `MemoryLow`, `MemoryHigh`, `MemoryHigh` matchers were incorrect. They do not support a "Soft:Hard" setting like the ulimit settings `LimitFSize` and similar. * https://github.com/systemd/systemd/blame/main/src/basic/format-util.c
|
centos failures are not related. |
Merged
traylenator
added a commit
to traylenator/puppet-systemd
that referenced
this pull request
Mar 5, 2024
CPUQuota can be more that 100% A bug was introduced in voxpupuli#422 restricting it to the range from 0 to 100%. * https://www.freedesktop.org/software/systemd/man/latest/systemd.resource-control.html#CPUQuota=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Use the new types:
Systemd::Unit::AmountSystemd::Unit::PercentSystemd::Unit::AmountOrPercentA few points to note:
While some documentation only mentions up to Tera the systemd code supports up to Peta and Exa. Some man pages are correct.
The
MemoryLow,MemoryHigh,MemoryHighmatchers were incorrect. They do not support a "Soft:Hard" setting like the ulimit settingsLimitFSizeand similar.https://github.com/systemd/systemd/blame/main/src/basic/format-util.c