Use a space-separated in timesyncd.conf #50
Conversation
According to timesyncd.conf(5) in man, NTP and FallbackNTP need a space-separated list: https://www.freedesktop.org/software/systemd/man/timesyncd.conf.html
README.md
Outdated
| $ntp_server => '0.pool.ntp.org,1.pool.ntp.org', | ||
| $fallback_ntp_server => '2.pool.ntp.org,3.pool.ntp.org', | ||
| $ntp_server => '0.pool.ntp.org 1.pool.ntp.org', | ||
| $fallback_ntp_server => '2.pool.ntp.org 3.pool.ntp.org', |
There was a problem hiding this comment.
How about passing an array instead?
There was a problem hiding this comment.
$ntp_server and $fallback_ntp_server in systemd class now don't allow Array: https://github.com/camptocamp/puppet-systemd/blob/1.1.0/manifests/init.pp#L43-L44
There was a problem hiding this comment.
IMO, it's better that systemd class allow $ntp_server and $ntp_fallback_server to use both Array and String. If you're okay, I'll do.
There was a problem hiding this comment.
Oh ok. That's weird, cause the timesyncd class accepts arrays. @bastelfreak you originally wrote that class, what do you think?
There was a problem hiding this comment.
Sounds like an oversight and init.pp should match the types of timesyncd.pp
There was a problem hiding this comment.
spaces are correct, not sure how I missed it. @hfm can you also allow array as datatype in the init.pp?
According to timesyncd.conf(5) in man, NTP and FallbackNTP need a space-separated list: https://www.freedesktop.org/software/systemd/man/timesyncd.conf.html