modulesync #1
Merged
modulesync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failing tests will be fixed by #3 |
smortex
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Probably fine. Please rebase on top of master to re-trigger CI when the other PRs are merged to check if the tests are green.
Since these change seems to fix a module that is not currently working, maybe we don't need PR for each change and fixes can be added on top of this branch.
bastelfreak
reviewed
Oct 4, 2023
.fixtures.yml
Outdated
Comment on lines
6
to
7
| systemd: "puppet/systemd" | ||
| stdlib: "puppetlabs/stdlib" |
There was a problem hiding this comment.
Please use links to git repos instead:
fixtures:
repositories:
stdlib: https://github.com/puppetlabs/puppetlabs-stdlib.git
systemd: https://github.com/voxpupuli/puppet-systemd.git
We test against the main branches of our dependencies to detect breaking changes before they are released. We use forge releases within our acceptance tests.
bastelfreak
approved these changes
Oct 4, 2023
|
Ready for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First module sync on new module